Add support for incremental compile #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
approved these changes
Aug 2, 2022
| manifestSigner = manifestSigner | ||
| ) | ||
| if (inputChanges.isIncremental) { | ||
| val filterByChangeType: ((ChangeType) -> Boolean) -> List<File> = { filter -> |
There was a problem hiding this comment.
ooooh this is a tricky signature
There was a problem hiding this comment.
Could this be a fun instead of a val ?
fun filesByChangeType(changeType: ChangeType): List<File> {
inputChanges.getFileChanges(inputDir)
.filter { filter(it.changeType) }
.map { outputDir.file(it.normalizedPath).get().asFile }
}
There was a problem hiding this comment.
Yeah, this is the problem with incremental refactors 😅 - definitely should be a fun instead.
| writeManifest(outputDir, mainFunction, mainModuleId, manifestSigner, modules) | ||
| } | ||
|
|
||
| fun incrementalCompile( |
| }.quickjsBytecode.toByteArray()) | ||
| } | ||
|
|
||
| assertZiplineIncrementalCompile("$rootProject/base", |
swankjesse
reviewed
Aug 2, 2022
| hashingSink.hash | ||
| } | ||
| val jsFiles = getJsFiles(inputDir.listFiles()!!.asList()) | ||
| jsFiles.forEach { jsFile -> compileSingleFile(jsFile, outputDir, modules) } |
There was a problem hiding this comment.
do we need to skip non-.js files?
There was a problem hiding this comment.
getJsFiles handles that
JakeWharton
approved these changes
Aug 2, 2022
zipline-gradle-plugin/src/main/kotlin/app/cash/zipline/gradle/ZiplineCompileTask.kt
Outdated
Show resolved
Hide resolved
zipline-gradle-plugin/src/main/kotlin/app/cash/zipline/gradle/ZiplineCompiler.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+94
to
+97
| // Clean up dir from previous runs | ||
| if (outputDir.exists()) { | ||
| outputDir.deleteRecursively() | ||
| } |
There was a problem hiding this comment.
Should probably use a JUnit temporary directory rule here to ensure a clear slate
There was a problem hiding this comment.
Maybe I'll do this as a separate PR, since really we should do this for all test, not just the incremental ones.
…ZiplineCompileTask.kt Co-authored-by: Jake Wharton <jw@squareup.com>
…ZiplineCompiler.kt Co-authored-by: Jake Wharton <jw@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.