Revise go script #125

Merged
merged 1 commit into from Oct 16, 2013

Conversation

Projects
None yet
3 participants
Contributor

eflynn commented Oct 16, 2013

Now more user-friendly. Removed -q option from git clone.

@lunaryorn lunaryorn added a commit that referenced this pull request Oct 16, 2013

@lunaryorn lunaryorn Merge pull request #125 from foobarman/revise-go-script
Revise go script
37f12fe

@lunaryorn lunaryorn merged commit 37f12fe into cask:v0.5-wip Oct 16, 2013

Contributor

lunaryorn commented Oct 16, 2013

@foobarman Thank you. I have merged this request. However, please do not make further changes to the script. We intend to re-write it in Python, and might thus not be able to merge further pull requests.

Contributor

eflynn commented Oct 16, 2013

You could write a script in elisp. Elisp supports the shebang like this:

#!/usr/bin/env emacs --script
Contributor

eflynn commented Oct 16, 2013

By the way, what is this project's license?

Contributor

lunaryorn commented Oct 16, 2013

@foobarman But Linux does not, nor can we assume that any other Unix system does. Besides, there are other drawbacks with an Emacs Lisp go script.

Most notably, we cannot control which Emacs version is used to invoke it, so we would have to remain compatible with at least Emacs 22 (system Emacs on OS X). Keeping the go script out of Emacs allows us to more cleverly choose the Emacs to use for cask. For instance, we might directly support an Emacs App bundle, instead of requiring an emacs executable in $PATH.

Contributor

lunaryorn commented Oct 16, 2013

@foobarman The license is GPL 3 or later, as usual.

Contributor

lunaryorn commented Oct 16, 2013

@foobarman We should probably mention this in README.md and add the license text as COPYING. @rejeep ?

Owner

rejeep commented Oct 16, 2013

Well, I guess it makes sense. It says so in all the el files, but it wouldn't hurt being verbose.

@lunaryorn lunaryorn added a commit that referenced this pull request Oct 19, 2013

@lunaryorn lunaryorn Add license information [#125] 24316d0
Contributor

lunaryorn commented Oct 19, 2013

@rejeep I added licensing information in ceebd66 (file headers) and 24316d0 (readme and license text). I think we should add it to the website as well. Can you do that?

Owner

rejeep commented Oct 19, 2013

@lunaryorn Sure! Are you thinking "License" in the menu with the complete GPL license?

Contributor

lunaryorn commented Oct 19, 2013

@rejeep That's likely the best. Probably between “Contribution” and “Source”… or at the very end of the menu bar.

Most people don't care anyway, but I think we should make it easy to find out the licensing condition for those who care.

Contributor

lunaryorn commented Oct 19, 2013

Great! Thanks
Am 19.10.2013 20:11 schrieb "Johan Andersson" notifications@github.com:

http://cask.github.io/license/


Reply to this email directly or view it on GitHubhttps://github.com/cask/cask/pull/125#issuecomment-26655510
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment