Add valign-mode #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
非常感谢！我手动merge一下。 |
|
哦对，有个问题，能不能用Emacs的格式写commit信息然后force push一下？我好像改不了你的commit信息。 |
|
未来有没有入 gnu elpa 的打算？ 有的话， 协议是否签署就应该注意了 |
|
有，签过了，我知道你也签过了。 |
|
现在惟一的一个问题（也是我一开始没有写实现valign-mode的原因）是关闭valign-mode不会把已经对齐的表格变回去。不过大概这个功能也不是很必要。以后有人提要求再说吧。 |
* valign.el: Add URL, Version, Keywords and Package-Requires. (valign--pixel-width-from-to, valign--beginning-of-table) (valign--end-of-table, valign--align-separator-row): Fix package-lint and checkdoc warns
* valign.el (valign-lighter): New variable. (valign-org-mode-hook): New function. (valign-mode): New minor mode. (valign-setup): Use valign-mode.
我觉得这个功能是必要的，最起码 C-c C-c 之后，要变动，我目前测试发现，valign-mode 切换后需要重新打开文件才能生效 |
|
是的，切换后同步效果可以我来写，你把目前的整理好我就merge。 |
|
应该可以合并了。 |
casouri
reviewed
May 29, 2020
* valign.el (valign-org-agenda-finalize-hook): New function. (valign-mode): use valign-org-agenda-finalize-hook.
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.