Speedup draw-tree (+ document diff-keys) #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdtsmith
changed the title
|
This speeds up draw-tree by >25x by eliminating most calls to |
jdtsmith
changed the title
|
Thanks! Merged. It would be even better if the commit message are written in the right format though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple fixes makes calls to
(current-column)happen only when needed duringdraw-tree-- when there is no room for a new branch. Sincecurrent-columngets quite slow on long lines, calling it unnecessarily on each node in the tree leads to major (quadratically bad) slowdown.