Replace key bytes and char length details (CD-93) #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRoussac
reviewed
Jun 19, 2025
docs/concepts/accounts-and-keys.md
Outdated
| ``` | ||
|
|
||
| The public-key-hex for `Secp256k1` keys starts with 02 and is 68 bytes long: | ||
| The public-key-hex for `Secp256k1` keys starts with 02 and is 68 characters / 33 bytes long: |
There was a problem hiding this comment.
@devendran-m I believe 68 means 34 bytes, simply divided by two
Contributor
Author
There was a problem hiding this comment.
Thanks, @gRoussac , and sorry for the oversight. I've addressed it now.
gRoussac
reviewed
Jun 19, 2025
| 3. `secret_key.pem` is the *PEM*-encoded secret key | ||
|
|
||
| The public-key-hex for `Ed25519` keys starts with 01 and is 66 bytes long: | ||
| The public-key-hex for `Ed25519` keys starts with 01 and is 66 characters / 32 bytes long: |
Contributor
Author
There was a problem hiding this comment.
Thanks, @gRoussac , and sorry for the oversight. I've addressed it now.
gRoussac
reviewed
Jun 19, 2025
| ``` | ||
|
|
||
| The public-key-hex for `Secp256k1` keys starts with 02 and is 68 bytes long: | ||
| The public-key-hex for `Secp256k1` keys starts with 02 and is 68 characters / 33 bytes long: |
Contributor
Author
There was a problem hiding this comment.
Thanks, @gRoussac , and sorry for the oversight. I've addressed it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA CD-93 - Replace occurrences of
bytesbycharsin Accounts and Keys sectionDESCRIPTION:
This PR replaces occurrences of "bytes" with "chars" in the Accounts and Keys section of the documentation.
Changes include;
CHANGELOG: