Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra forces json gem #13

Closed
mperham opened this issue Mar 3, 2010 · 3 comments
Closed

Cassandra forces json gem #13

mperham opened this issue Mar 3, 2010 · 3 comments

Comments

@mperham
Copy link
Contributor

mperham commented Mar 3, 2010

We'd like to use yajl-ruby's JSON gem compatibility API instead of the json gem. Would it be possible to remove the explicit dependency and just check for defined?(JSON) upon startup? Or remove the need for JSON at all (I noticed it's only used in one place)?

@ryanking
Copy link
Contributor

ryanking commented Mar 3, 2010

We won't be able to remove the dependency on json yet, but we could do this:

require 'json' unless defined?(JSON)

...which would let you load yajl before you load cassandra.

@mperham
Copy link
Contributor Author

mperham commented Mar 3, 2010

I'd prefer not to have the json gem packaged with my app at all but your suggestion at least improves the status quo so consider me in favor.

@jmhodges
Copy link
Contributor

jmhodges commented Mar 4, 2010

Done in 66659b1.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants