get_indexed_slices: key_start -> start_key (for API consistency) #155

Merged
merged 9 commits into from Aug 6, 2012

Conversation

Projects
None yet
2 participants
@mcmire
Contributor

mcmire commented Aug 5, 2012

Implementation of #153. (I guess there weren't any tests for that option, hmm.)

@natemueller

This comment has been minimized.

Show comment Hide comment
@natemueller

natemueller Aug 5, 2012

Contributor

Can you add a test for the new API?

Contributor

natemueller commented Aug 5, 2012

Can you add a test for the new API?

@mcmire

This comment has been minimized.

Show comment Hide comment
@mcmire

mcmire Aug 6, 2012

Contributor

Had to rewrite the tests for get_indexed_slices a bit, but there you go. I also took the opportunity to add tests for create_index_clause and create_index_expression.

Contributor

mcmire commented Aug 6, 2012

Had to rewrite the tests for get_indexed_slices a bit, but there you go. I also took the opportunity to add tests for create_index_clause and create_index_expression.

natemueller added a commit that referenced this pull request Aug 6, 2012

Merge pull request #155 from mcmire/issue_153
get_indexed_slices: key_start -> start_key (for API consistency)

@natemueller natemueller merged commit 3815dd0 into cassandra-rb:master Aug 6, 2012

@natemueller

This comment has been minimized.

Show comment Hide comment
@natemueller

natemueller Aug 6, 2012

Contributor

Thanks.

Contributor

natemueller commented Aug 6, 2012

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment