Update thrift_client version dependency #173

Open
wants to merge 2 commits into
from

5 participants

@mikebaldry

to make use of encoding fixes in thrift_client 0.10 that allow saving(or sending over thrift_client) of binary data.

@natemueller

It looks like there were a bunch of test failures on 1.9.3. Any idea what those might be from?

@tsenart

From the build output we can clearly see that the thrift version is wrong, given that the version you wanted was 0.10.

 1) Error:
187test_batch_mutate(CassandraTest):
188Encoding::UndefinedConversionError: "\x81" from ASCII-8BIT to UTF-8
189    /home/travis/.rvm/gems/ruby-1.9.3-p327/gems/thrift-0.9.0/lib/thrift/bytes.rb:81:in `encode'
190    /home/travis/.rvm/gems/ruby-1.9.3-p327/gems/thrift-0.9.0/lib/thrift/bytes.rb:81:in `convert_to_utf8_byte_buffer'
....
@chrishsin

the commit wrote thrift should less than 0.10
p.dependencies = ['thrift_client >=0.7.0 <0.10'

so I think test failure shouldn't be the version checking.
anybody has other idea?

@flrngel

I wonder why dependencies won't change. And I found that I was doing wrong..
I didn't know I should re-build after changing gemspec and Rakefile..
Here's some tips for totally newbies like me..

/ $ bundle show cassandra
-> blah blah

in ..

change as 3bedcd2, bd4afd3 above,

$ gem build cassandra.gemspec
$ mv cassandra-0.17.0.gem ~/
$ cd ~/
$ sudo gem install cassandra-0.17.0.gem
$ cd
$ bundle update

ofcourse I know it is not the solution.. but i solved the super duper errors now..

goodluck everybody

@natemueller

Looks like the test failures are caused by THRIFT-1023. They now assume any strings passed in are UTF-8, which is not the case for things like UUIDs. Not sure what the proper resolution is.

@natemueller

Looks like this is fixed on thrift trunk. Need to wait for a 0.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment