Update thrift_client version dependency #173

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants
@mikebaldry

to make use of encoding fixes in thrift_client 0.10 that allow saving(or sending over thrift_client) of binary data.

@natemueller

This comment has been minimized.

Show comment Hide comment
@natemueller

natemueller Jan 23, 2013

Contributor

It looks like there were a bunch of test failures on 1.9.3. Any idea what those might be from?

Contributor

natemueller commented Jan 23, 2013

It looks like there were a bunch of test failures on 1.9.3. Any idea what those might be from?

@tsenart

This comment has been minimized.

Show comment Hide comment
@tsenart

tsenart Jan 29, 2013

From the build output we can clearly see that the thrift version is wrong, given that the version you wanted was 0.10.

 1) Error:
187test_batch_mutate(CassandraTest):
188Encoding::UndefinedConversionError: "\x81" from ASCII-8BIT to UTF-8
189    /home/travis/.rvm/gems/ruby-1.9.3-p327/gems/thrift-0.9.0/lib/thrift/bytes.rb:81:in `encode'
190    /home/travis/.rvm/gems/ruby-1.9.3-p327/gems/thrift-0.9.0/lib/thrift/bytes.rb:81:in `convert_to_utf8_byte_buffer'
....

tsenart commented Jan 29, 2013

From the build output we can clearly see that the thrift version is wrong, given that the version you wanted was 0.10.

 1) Error:
187test_batch_mutate(CassandraTest):
188Encoding::UndefinedConversionError: "\x81" from ASCII-8BIT to UTF-8
189    /home/travis/.rvm/gems/ruby-1.9.3-p327/gems/thrift-0.9.0/lib/thrift/bytes.rb:81:in `encode'
190    /home/travis/.rvm/gems/ruby-1.9.3-p327/gems/thrift-0.9.0/lib/thrift/bytes.rb:81:in `convert_to_utf8_byte_buffer'
....
@chrishsin

This comment has been minimized.

Show comment Hide comment
@chrishsin

chrishsin Feb 22, 2013

the commit wrote thrift should less than 0.10
p.dependencies = ['thrift_client >=0.7.0 <0.10'

so I think test failure shouldn't be the version checking.
anybody has other idea?

the commit wrote thrift should less than 0.10
p.dependencies = ['thrift_client >=0.7.0 <0.10'

so I think test failure shouldn't be the version checking.
anybody has other idea?

@flrngel

This comment has been minimized.

Show comment Hide comment
@flrngel

flrngel Mar 7, 2013

I wonder why dependencies won't change. And I found that I was doing wrong..
I didn't know I should re-build after changing gemspec and Rakefile..
Here's some tips for totally newbies like me..

<app_dir>/ $ bundle show cassandra
-> <cassandra_dir> blah blah

in <cassandra_dir> ..

change as 3bedcd2, bd4afd3 above,

$ gem build cassandra.gemspec
$ mv cassandra-0.17.0.gem ~/
$ cd ~/
$ sudo gem install cassandra-0.17.0.gem
$ cd <app_dir>
$ bundle update

ofcourse I know it is not the solution.. but i solved the super duper errors now..

goodluck everybody

flrngel commented Mar 7, 2013

I wonder why dependencies won't change. And I found that I was doing wrong..
I didn't know I should re-build after changing gemspec and Rakefile..
Here's some tips for totally newbies like me..

<app_dir>/ $ bundle show cassandra
-> <cassandra_dir> blah blah

in <cassandra_dir> ..

change as 3bedcd2, bd4afd3 above,

$ gem build cassandra.gemspec
$ mv cassandra-0.17.0.gem ~/
$ cd ~/
$ sudo gem install cassandra-0.17.0.gem
$ cd <app_dir>
$ bundle update

ofcourse I know it is not the solution.. but i solved the super duper errors now..

goodluck everybody

@natemueller

This comment has been minimized.

Show comment Hide comment
@natemueller

natemueller Aug 6, 2013

Contributor

Looks like the test failures are caused by THRIFT-1023. They now assume any strings passed in are UTF-8, which is not the case for things like UUIDs. Not sure what the proper resolution is.

Contributor

natemueller commented Aug 6, 2013

Looks like the test failures are caused by THRIFT-1023. They now assume any strings passed in are UTF-8, which is not the case for things like UUIDs. Not sure what the proper resolution is.

@natemueller

This comment has been minimized.

Show comment Hide comment
@natemueller

natemueller Aug 6, 2013

Contributor

Looks like this is fixed on thrift trunk. Need to wait for a 0.10 release.

Contributor

natemueller commented Aug 6, 2013

Looks like this is fixed on thrift trunk. Need to wait for a 0.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment