Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Some TODO test revisions prompted by RT#59565

  • Loading branch information...
commit b9df8e39d03e6da167b2598f6ee70fb16c069112 1 parent c271eec
@ribasushi ribasushi authored
View
2  Changes
@@ -27,6 +27,8 @@ Revision history for DBIx::Class
- Makefile.PL no longer imports GetOptions() to interoperate
better with Catalyst installers
- Bumped minimum Module::Install for developers
+ - Bumped DBD::SQLite dependency and removed some TODO markers
+ from tests
0.08123 2010-06-12 14:46 (UTC)
* Fixes
View
2  Makefile.PL
@@ -35,7 +35,7 @@ perl_version '5.008001';
all_from 'lib/DBIx/Class.pm';
my $build_requires = {
- 'DBD::SQLite' => '1.25',
+ 'DBD::SQLite' => '1.29',
};
my $test_requires = {
View
6 t/64db.t
@@ -1,5 +1,5 @@
use strict;
-use warnings;
+use warnings;
use Test::More;
use lib qw(t/lib);
@@ -47,9 +47,7 @@ is_deeply (
'Correctly retrieve column info (no size or is_nullable)'
);
-TODO: {
- local $TODO = 'All current versions of SQLite seem to mis-report is_nullable';
-
+{
is_deeply (
get_storage_column_info ($schema->storage, 'artist', qw/size/),
{
View
14 t/prefetch/via_search_related.t
@@ -9,6 +9,10 @@ use DBICTest;
my $schema = DBICTest->init_schema();
+my $queries;
+my $debugcb = sub { $queries++; };
+my $orig_debug = $schema->storage->debug;
+
lives_ok ( sub {
my $no_prefetch = $schema->resultset('Track')->search_related(cd =>
{
@@ -126,9 +130,19 @@ lives_ok (sub {
TODO: {
local $TODO = "This makes another 2 trips to the database, it can't be right";
+
+ $queries = 0;
+ $schema->storage->debugcb ($debugcb);
+ $schema->storage->debug (1);
+
# artist -> 2 cds -> 2 genres -> 2 cds for each genre + distinct = 2
is($rs->search_related('cds')->all, 2, 'prefetched distinct with prefetch (objects)');
is($rs->search_related('cds')->count, 2, 'prefetched distinct with prefetch (count)');
+
+ is ($queries, 0, 'No extra queries fired (prefetch survives search_related)');
+
+ $schema->storage->debugcb (undef);
+ $schema->storage->debug ($orig_debug);
}
}, 'distinct generally works with prefetch on deep search_related chains');
View
1  t/row/inflate_result.t
@@ -91,7 +91,6 @@ TODO: {
is( ref $user, 'My::Schema::Result::User' );
is( ref $admin, 'My::Schema::Result::User::Admin' );
-
}
my $user = $schema->resultset('User')->single($user_data);
Please sign in to comment.
Something went wrong with that request. Please try again.