Skip to content

SerilogLogger implementation bug #66

@siewers

Description

@siewers

Hi,

I just discovered a rather annoying issue in the SerilogLogger implementation.
Calling

Fatal(string messageTemplate, Exception exception) 

delegates to

Logger.Fatal(string messageTemplate, params object[] propertyValues)

which essentially makes the exception dissapear.

I've just hunted down this bug, and can confirm that FatalFormat(Exception exception, string format) works correctly.

I would guess a simple switch in the parameters would make it work as intended, but I'm not sure.

Basically I'm guessing there might be some issues with the current ILogger interface for supporting Serilog's semantic logging?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions