Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
I just discovered a rather annoying issue in the SerilogLogger implementation.
Fatal(string messageTemplate, Exception exception)
Logger.Fatal(string messageTemplate, params object propertyValues)
which essentially makes the exception dissapear.
I've just hunted down this bug, and can confirm that FatalFormat(Exception exception, string format) works correctly.
I would guess a simple switch in the parameters would make it work as intended, but I'm not sure.
Basically I'm guessing there might be some issues with the current ILogger interface for supporting Serilog's semantic logging?
The text was updated successfully, but these errors were encountered:
Added some TODOs where we don't currently pass through the args array…
… because we honour the IFormatProvider instead, which causes Serilog to get just a already formatted string rather than its normal structured logging. #66
Thanks for reporting the defect. I've just fixed it and published v3.3.2:
Sorry, something went wrong.
Fantastic! Thanks a lot :)
Successfully merging a pull request may close this issue.