Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerilogLogger implementation bug #66

Closed
siewers opened this issue Oct 31, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@siewers
Copy link
Contributor

commented Oct 31, 2014

Hi,

I just discovered a rather annoying issue in the SerilogLogger implementation.
Calling

Fatal(string messageTemplate, Exception exception) 

delegates to

Logger.Fatal(string messageTemplate, params object[] propertyValues)

which essentially makes the exception dissapear.

I've just hunted down this bug, and can confirm that FatalFormat(Exception exception, string format) works correctly.

I would guess a simple switch in the parameters would make it work as intended, but I'm not sure.

Basically I'm guessing there might be some issues with the current ILogger interface for supporting Serilog's semantic logging?

@jonorossi jonorossi closed this in c6be0f1 Nov 3, 2014

jonorossi added a commit that referenced this issue Nov 3, 2014

Added some TODOs where we don't currently pass through the args array…
… because we honour the IFormatProvider instead, which causes Serilog to get just a already formatted string rather than its normal structured logging. #66
@jonorossi

This comment has been minimized.

Copy link
Member

commented Nov 3, 2014

Thanks for reporting the defect. I've just fixed it and published v3.3.2:
https://github.com/castleproject/Core/releases/tag/v3.3.2

@siewers

This comment has been minimized.

Copy link
Contributor Author

commented Nov 3, 2014

Fantastic! Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.