XmlAdapter Improvements #3

Merged
merged 4 commits into from Dec 6, 2011

Conversation

Projects
None yet
4 participants
Contributor

sharpjs commented Dec 6, 2011

  • Use weak-ref keys for reference tracker.
  • IBindingListSource

@cneuwirt cneuwirt added a commit that referenced this pull request Dec 6, 2011

@cneuwirt cneuwirt Merge pull request #3 from sharpjs/sharpjs
XmlAdapter Improvements
bd8fdf3

@cneuwirt cneuwirt merged commit bd8fdf3 into castleproject:master Dec 6, 2011

Contributor

k0st1x commented on 80de1b3 Dec 8, 2011

IBindingListSource is declared for non SILVERLIGHT, but IBindingList implements IBindingListSource.
http://builds.castleproject.org/viewLog.html?buildId=9333&tab=buildResultsDiv&buildTypeId=bt95

Contributor

kkozmic replied Dec 10, 2011

Good catch @k0st1x

@sharpjs was the goal to put the change from IBindingList line 21 in line 23?

Contributor

sharpjs replied Dec 10, 2011

@kkozmic Yes, that was my intent. Thanks @k0st1x for noticing!

I'll prepare a pull request to fix it.

Contributor

kkozmic replied Dec 10, 2011

@sharpjs no worries, I'll do it.

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment