We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi @MXueguang - I propose the following renaming:
IndexVectorCollection
IndexDenseVectors
VectorCollection
JsonDenseVectorCollection
BinaryDenseVectorCollection
LuceneVectorDocumentGenerator
LuceneDenseVectorDocumentGenerator
IndexVectorArgs
IndexDenseVectors.Args
SearchVectorCollection
SearchDenseVectors
The key distinction here is between "dense" and "sparse"... because BM25 is a vector also...
So we can have in parallel (perhaps later):
IndexCollection
IndexSparseCollection
IndexArgs
IndexSparseCollection.Args
The text was updated successfully, but these errors were encountered:
MXueguang
No branches or pull requests
Hi @MXueguang - I propose the following renaming:
IndexVectorCollection
->IndexDenseVectors
VectorCollection
->JsonDenseVectorCollection
(later, we can haveBinaryDenseVectorCollection
, etc.)LuceneVectorDocumentGenerator
->LuceneDenseVectorDocumentGenerator
IndexVectorArgs
-> make it an inner classIndexDenseVectors.Args
SearchVectorCollection
->SearchDenseVectors
The key distinction here is between "dense" and "sparse"... because BM25 is a vector also...
So we can have in parallel (perhaps later):
IndexCollection
->IndexSparseCollection
IndexArgs
->IndexSparseCollection.Args
The text was updated successfully, but these errors were encountered: