Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Java 11 #743

Merged
merged 4 commits into from Jul 11, 2019

Conversation

Projects
None yet
3 participants
@lintool
Copy link
Member

commented Jul 11, 2019

Let's just do it...

@lintool lintool requested review from r-clancy and emmileaf Jul 11, 2019

@lintool

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

On this branch, if I want to still use JDK8, this appears to work fine in pom.xml:

-          <source>11</source>
-          <target>11</target>
-          <testSource>11</testSource>
-          <testTarget>11</testTarget>
+          <source>8</source>
+          <target>8</target>
+          <testSource>8</testSource>
+          <testTarget>8</testTarget>

Robust04 regression works fine.

Since this is technically @r-clancy PR, @emmileaf should review...

@emmileaf
Copy link
Collaborator

left a comment

LGTM, though should we also update the readme to explain this change?

@lintool

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@emmileaf yes, I'll do it. I'll prepare the README change before merging this.

@lintool

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Actually, I need to merge this to get the commit id to put in the README. Merging.

@lintool lintool merged commit 17b702d into master Jul 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lintool lintool deleted the java-11 branch Jul 11, 2019

Victor0118 added a commit to Victor0118/Anserini that referenced this pull request Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.