Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sm_model to sm_cnn_model #18

Closed
lintool opened this issue Apr 17, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@lintool
Copy link
Member

commented Apr 17, 2017

Might want to rename sm_model to sm_cnn_model to be consistent with @Jeffyrao 's impl?
https://github.com/castorini/SM-CNN-Torch

@lintool

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2017

Or even just sm_cnn?

@gauravbaruah

This comment has been minimized.

Copy link
Member

commented Apr 18, 2017

@rosequ @salman1993 How might the renaming affect the anserini e2e connection? Are there any hardcoded statements that will need to be addressed for this change?

@lintool

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2017

@gauravbaruah bumping this issue again. to be consistent with other models that we've merged in, should we rename to sm_cnn?

lintool added a commit that referenced this issue May 3, 2017

renaming sm_model; faster bridge (#18) (#22)
+ renamed sm_model
+ faster bridge by obtaining the IDF scores of a term directly from the Java server
@rosequ

This comment has been minimized.

Copy link
Member

commented May 4, 2017

This issue is resolved. Can we close it now?

@lintool lintool closed this May 4, 2017

tuzhucheng pushed a commit that referenced this issue Oct 5, 2017

renaming sm_model; faster bridge (#18) (#22)
+ renamed sm_model
+ faster bridge by obtaining the IDF scores of a term directly from the Java server

Ashutosh-Adhikari added a commit to Ashutosh-Adhikari/Castor that referenced this issue Dec 16, 2018

Merge pull request castorini#18 from achyudhk/master
Add single_label support for XML-CNN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.