Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add storing prediction/qrel files option for test set #125

Merged
merged 2 commits into from Jun 19, 2018

Conversation

Projects
None yet
2 participants
@Victor0118
Copy link
Member

commented Jun 18, 2018

@tuzhucheng Could you review this?

Thanks!

@tuzhucheng
Copy link
Member

left a comment

LGTM after addressing comments

os.remove(qrel_fname)
os.remove(results_fname)
if keep_results:
print("saving prediction file to {}".format(results_fname))

This comment has been minimized.

Copy link
@tuzhucheng

tuzhucheng Jun 18, 2018

Member

Please capitalize error message

This comment has been minimized.

Copy link
@Victor0118

Victor0118 Jun 19, 2018

Author Member

Thx!

train_evaluator = EvaluatorFactory.get_evaluator(dataset_cls, model, embedding, train_loader, args.batch_size, args.device)
test_evaluator = EvaluatorFactory.get_evaluator(dataset_cls, model, embedding, test_loader, args.batch_size, args.device)
dev_evaluator = EvaluatorFactory.get_evaluator(dataset_cls, model, embedding, dev_loader, args.batch_size, args.device)
train_evaluator = EvaluatorFactory.get_evaluator(dataset_cls, model, embedding, train_loader, args.batch_size,

This comment has been minimized.

Copy link
@tuzhucheng

tuzhucheng Jun 18, 2018

Member

If the help message is "store the output score and qrel files into disk for the test set" why is it added for training set as well?

This comment has been minimized.

Copy link
@Victor0118

Victor0118 Jun 19, 2018

Author Member

you are right. I will delete them.

@Victor0118 Victor0118 merged commit 921a45e into castorini:master Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.