Make arm/leg components of armor sets consistent with rest of set #831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix arm and leg guards that are part of an armor set having wildly different properties"
Purpose of change
I noticed while fumbling to get leather armor produced that leather arm guards, intended to be worn with leather body armor, and being used together to craft the plated and boiled armor sets, didn't behave the same as leather body armor. It was on the strapped layer instead of normal, and wasn't variable in size.
Describe the solution
STRAPPEDflag. Now consistent with leather body armor.STRAPPEDflag from chitin and acidchitin arm guards, to be consistent with the body armor item.STRAPPEDwithOUTERfor plate arm and leg guards, to be consistent with cuirass and with assembled plate armor.Describe alternatives you've considered
BLOCK_WHILE_WORNas well, seems acceptable to have it on. For leather arm guards it's a trade off between upgrading your armor vs. retaining the freedom to block with the arm guards, and chitin arm guards don't have any upgraded merged sets where it'd lose the flag. Steel arm guards losing theBLOCK_WHILE_WORNon being crafted into plate armor, with no advantage to make up for it, is the only real oddity resulting from that.Testing
Ported JSON changes over to check for syntax errors, ran affected files through linter.
Additional context