Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ID for mutation types and mutations #855

Merged
merged 2 commits into from Sep 9, 2021

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Sep 5, 2021

Summary

SUMMARY: Bugfixes "Fix mutation and mutation type IDs accidentally changed to lowercase"

Purpose of change

Quick and easy fix to make to not trip up third-party mods. Confirmed with Coolthulhu on the BN discord that re-capitalizing mutation type LEGS and HANDS would be preferable.

Describe the solution

  1. Fixed capitalization of mutation type LEGS and HANDS
  2. Fixed mutation type for affected vanilla mutations.
  3. Fixed mutation type for affected mod mutations, only Aftershock was affected.
  4. Was also informed that three mutation IDs were affected by this, easy fix.

Describe alternatives you've considered

Just changing the case used in Arcana, only third-party mod I'm involved with that would be affected by this if I recall.

Testing

Checked affected files for syntax and load errors.

Additional context

Hopefully not too many modders will have tweaked this for BN versions of their mods by the time this is merged...

@olanti-p
Copy link
Member

olanti-p commented Sep 6, 2021

Some mutation ids also suffered:
headBUMPS
mouth_FLAPS
mouth_TENTACLES

@chaosvolt
Copy link
Member Author

Oh hecc, Yeah that's not good. I'll add fixes for that to this while I'm at it.

@chaosvolt chaosvolt changed the title Fix ID for mutation types Fix ID for mutation types and mutations Sep 6, 2021
@Coolthulhu Coolthulhu self-assigned this Sep 9, 2021
@Coolthulhu Coolthulhu merged commit bccd5cc into cataclysmbnteam:upload Sep 9, 2021
@chaosvolt chaosvolt deleted the mutation-type-fix branch September 9, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants