From 2c82f82ee211b011460f2f44647b69e0feaf3d4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Wed, 15 Sep 2021 21:29:10 +0200 Subject: [PATCH] Mark first party reporters final They are not intended to be derived from, so forbidding it explicitly improves our ability to refactor them later. --- src/catch2/reporters/catch_reporter_automake.hpp | 2 +- src/catch2/reporters/catch_reporter_compact.hpp | 2 +- src/catch2/reporters/catch_reporter_console.hpp | 2 +- src/catch2/reporters/catch_reporter_junit.hpp | 2 +- src/catch2/reporters/catch_reporter_sonarqube.hpp | 2 +- src/catch2/reporters/catch_reporter_tap.hpp | 2 +- src/catch2/reporters/catch_reporter_teamcity.hpp | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/catch2/reporters/catch_reporter_automake.hpp b/src/catch2/reporters/catch_reporter_automake.hpp index 6e376e902a..84fad79027 100644 --- a/src/catch2/reporters/catch_reporter_automake.hpp +++ b/src/catch2/reporters/catch_reporter_automake.hpp @@ -12,7 +12,7 @@ namespace Catch { - struct AutomakeReporter : StreamingReporterBase { + struct AutomakeReporter final : StreamingReporterBase { AutomakeReporter( ReporterConfig const& _config ) : StreamingReporterBase( _config ) {} diff --git a/src/catch2/reporters/catch_reporter_compact.hpp b/src/catch2/reporters/catch_reporter_compact.hpp index 0c632f765a..b39bd18ae2 100644 --- a/src/catch2/reporters/catch_reporter_compact.hpp +++ b/src/catch2/reporters/catch_reporter_compact.hpp @@ -14,7 +14,7 @@ namespace Catch { - struct CompactReporter : StreamingReporterBase { + struct CompactReporter final : StreamingReporterBase { using StreamingReporterBase::StreamingReporterBase; diff --git a/src/catch2/reporters/catch_reporter_console.hpp b/src/catch2/reporters/catch_reporter_console.hpp index 5a1765b3c5..ec74309352 100644 --- a/src/catch2/reporters/catch_reporter_console.hpp +++ b/src/catch2/reporters/catch_reporter_console.hpp @@ -16,7 +16,7 @@ namespace Catch { struct SummaryColumn; class TablePrinter; - struct ConsoleReporter : StreamingReporterBase { + struct ConsoleReporter final : StreamingReporterBase { Detail::unique_ptr m_tablePrinter; ConsoleReporter(ReporterConfig const& config); diff --git a/src/catch2/reporters/catch_reporter_junit.hpp b/src/catch2/reporters/catch_reporter_junit.hpp index 3d68b7f600..6665663cee 100644 --- a/src/catch2/reporters/catch_reporter_junit.hpp +++ b/src/catch2/reporters/catch_reporter_junit.hpp @@ -15,7 +15,7 @@ namespace Catch { - class JunitReporter : public CumulativeReporterBase { + class JunitReporter final : public CumulativeReporterBase { public: JunitReporter(ReporterConfig const& _config); diff --git a/src/catch2/reporters/catch_reporter_sonarqube.hpp b/src/catch2/reporters/catch_reporter_sonarqube.hpp index a4f60ea632..720c0ea0fb 100644 --- a/src/catch2/reporters/catch_reporter_sonarqube.hpp +++ b/src/catch2/reporters/catch_reporter_sonarqube.hpp @@ -14,7 +14,7 @@ namespace Catch { - struct SonarQubeReporter : CumulativeReporterBase { + struct SonarQubeReporter final : CumulativeReporterBase { SonarQubeReporter(ReporterConfig const& config) : CumulativeReporterBase(config) diff --git a/src/catch2/reporters/catch_reporter_tap.hpp b/src/catch2/reporters/catch_reporter_tap.hpp index 8785584797..e7c22cfa9c 100644 --- a/src/catch2/reporters/catch_reporter_tap.hpp +++ b/src/catch2/reporters/catch_reporter_tap.hpp @@ -12,7 +12,7 @@ namespace Catch { - struct TAPReporter : StreamingReporterBase { + struct TAPReporter final : StreamingReporterBase { TAPReporter( ReporterConfig const& config ): StreamingReporterBase( config ) { diff --git a/src/catch2/reporters/catch_reporter_teamcity.hpp b/src/catch2/reporters/catch_reporter_teamcity.hpp index f387cafb15..7abe818530 100644 --- a/src/catch2/reporters/catch_reporter_teamcity.hpp +++ b/src/catch2/reporters/catch_reporter_teamcity.hpp @@ -20,7 +20,7 @@ namespace Catch { - struct TeamCityReporter : StreamingReporterBase { + struct TeamCityReporter final : StreamingReporterBase { TeamCityReporter( ReporterConfig const& _config ) : StreamingReporterBase( _config ) {