Skip to content
Permalink
Browse files

Fix coverage report merging

For some time now (I'd guess almost a year :shrug:), the coverage
merging on Windows has been failing, because the reports have been
generated in a different folder than expected. Our merge script did
not report failure because it was not checking the returned error
code from OpenCppCoverage, and for some reason, the `codecov` tool
happily returned 0 even though it did not find the file it was
supposed to upload...

The former is also fixed by this commit.
  • Loading branch information...
horenmar committed Jul 20, 2019
1 parent 0b42ada commit fb74bb133ccc8b1bbf932071f3db039861dea73a
Showing with 2 additions and 2 deletions.
  1. +2 −2 misc/appveyorMergeCoverageScript.py
@@ -4,6 +4,6 @@
import subprocess

if __name__ == '__main__':
cov_files = list(glob.glob('cov-report*.bin'))
cov_files = list(glob.glob('projects/cov-report*.bin'))
base_cmd = ['OpenCppCoverage', '--quiet', '--export_type=cobertura:cobertura.xml'] + ['--input_coverage={}'.format(f) for f in cov_files]
subprocess.call(base_cmd)
subprocess.check_call(base_cmd)

0 comments on commit fb74bb1

Please sign in to comment.
You can’t perform that action at this time.