assertionEnded is not called on reporters

[berkus]

Description

I included TAPReporter, enabled it via cmdline but report always comes out as 1..0 with nothing else. After debugging for a while I found that assertionEnded method of the reporter is never called, and this is crucial place for actually counting the results.

Any ideas why that might be?

Steps to reproduce

1. #include "catch_reporters_tap.hpp"
2. test -r tap

Extra information

• Catch version: v2.2.2
• Operating System: macOS
• Compiler+version: Apple LLVM version 9.1.0 (clang-902.0.39.1)
  Target: x86_64-apple-darwin17.5.0

[berkus]

I see that void RunContext::assertionPassed() { does not call assertionEnded() with success.

[berkus]

And the fix was

        ConfigData data;
        data.showSuccessfulTests = true; // important for TAPReporter

I guess TAPReporter could set this internally in constructor, but i didn't test that yet.