New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML reporter writes encoding line to stdout, even if -o is specified #750

Closed
horenmar opened this Issue Nov 26, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@horenmar
Copy link
Member

horenmar commented Nov 26, 2016

I was testing another issue and fix when I came across the fact that if I run catch binary as small.exe -r xml -o test then the xml writer writes the line <?xml version="1.1" encoding="UTF-8"?> to stdout, even though it should be written to file test.

This is caused by XmlReporter improperly initializing XmlWriter.

PR coming soon.

@philsquared

This comment has been minimized.

Copy link
Collaborator

philsquared commented Nov 29, 2016

Thanks for raising this - and for the PR (#751) which I've now accepted.
I'm not sure how it got that way in the first place - must have been a refactoring artefact at some point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment