New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch includes windows.h without disabling worst parts #762

Closed
horenmar opened this Issue Dec 16, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@horenmar
Copy link
Member

horenmar commented Dec 16, 2016

Catch includes windows.h on Windows without defining NOMINMAX, meaning there is min and max macro in file where Catch defines main. This probably does not matter much in the usual use-case (where there is one file with

#define CATCH_CONFIG_MAIN
#include "catch.hpp"

but for user supplied main this can be very annoying.

Catch probably should also define WIN32_LEAN_AND_MEAN, before including windows.h, so it doesn't bring in symbols it does not need, speeding up main compilation and again, not polluting source file with user supplied main needlessly.

@horenmar

This comment has been minimized.

Copy link
Member

horenmar commented Jan 16, 2017

This is in.

@horenmar horenmar closed this Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment