Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: override implies virtual #1336

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
2 participants
@ax3l
Copy link
Contributor

commented Jul 12, 2018

Description

In C++, override implies virtual.

Another reference on SO:
https://stackoverflow.com/questions/43466863/isnt-virtual-keyword-redundant-when-override-or-final-specifiers-are-used

GitHub Issues

Detected via CodeFactor.io score in a downstream project: openPMD/openPMD-api#293

Refactor: override implies virtual
If not used with `final`, override implies `virtual`.
Detected via CodeFactor score.

Another reference on SO:
  https://stackoverflow.com/questions/43466863/isnt-virtual-keyword-redundant-when-override-or-final-specifiers-are-used
@codecov

This comment has been minimized.

Copy link

commented Jul 12, 2018

Codecov Report

Merging #1336 into master will decrease coverage by 1.85%.
The diff coverage is 72.73%.

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   80.72%   78.87%   -1.85%     
==========================================
  Files         121      113       -8     
  Lines        3423     3299     -124     
==========================================
- Hits         2763     2602     -161     
- Misses        660      697      +37
@ax3l

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

@horenmar ping :)

@horenmar

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

I've changed my mind on override + virtual redudancy in the meantime, so sure, why not.

@horenmar horenmar merged commit c3c82f5 into catchorg:master Apr 18, 2019

3 of 4 checks passed

codecov/patch 72.73% of diff hit (target 80%)
Details
codecov/project 78.87% (-1.85%) compared to 08147a2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ax3l ax3l deleted the ax3l:topic-overrideVirtualRedundant branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.