New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseAndAddCatchTests: Add PARSE_CATCH_TESTS_HIDDEN_TESTS_DISABLED option #1452

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@drdanz
Copy link
Contributor

drdanz commented Nov 21, 2018

This PR adds the PARSE_CATCH_TESTS_HIDDEN_TESTS_DISABLED option to ParseAndAddCatchTests.

If this option is enabled and PARSE_CATCH_TESTS_NO_HIDDEN_TESTS option is disabled, the test is be added, but the DISABLED property is set, therefore CTest shows it as Not Run (Disabled) instead of Passed.

The tests that are not executed do not count in the number of executed tests.

I think this would probably be a good option to have enabled by default, but it is set it to OFF instead, since this would change current behaviour, and since it the option does not exist before CMake 3.9

ParseAndAddCatchTests: Add PARSE_CATCH_TESTS_HIDDEN_TESTS_DISABLED op…
…tion

If this option is enabled and PARSE_CATCH_TESTS_NO_HIDDEN_TESTS option is disabled, the test is be added, but the DISABLED property is set, therefore CTest shows it as "Not Run (Disabled)" instead of "Passed"
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #1452 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1452   +/-   ##
=======================================
  Coverage   80.31%   80.31%           
=======================================
  Files         121      121           
  Lines        3407     3407           
=======================================
  Hits         2736     2736           
  Misses        671      671

@horenmar horenmar added the Contrib label Jan 11, 2019

@horenmar

This comment has been minimized.

Copy link
Member

horenmar commented Jan 11, 2019

Sorry for not getting to this sooner, and thanks for the PR.

I think that instead of having a separate option for this, the script should check whether the CMake version is modern enough (3.9+) and if it is, set the disabled property by default.

@horenmar

This comment has been minimized.

Copy link
Member

horenmar commented Jan 23, 2019

I merged the new code with the logic for hiding tests.

@horenmar horenmar merged commit 804a211 into catchorg:master Jan 23, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@drdanz drdanz deleted the drdanz:ParseAddAndCatchTest_DISABLED branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment