New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sigsegv stack overflow behavior #753

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@horenmar
Copy link
Member

horenmar commented Nov 26, 2016

Also stops Catch from assuming its the only signal user in the binary,
and makes it restore the signal handlers it has replaced. Same goes for
the signal stack.

The signal stack itself probably shouldn't be always reallocated for
fragmentation reasons, but that can be fixed later on.

Fix for sigsegv stack overflow behavior
Also stops Catch from assuming its the only signal user in the binary,
and makes it restore the signal handlers it has replaced. Same goes for
the signal stack.

The signal stack itself probably shouldn't be always reallocated for
fragmentation reasons, but that can be fixed later on.
@horenmar

This comment has been minimized.

Copy link
Member

horenmar commented Nov 28, 2016

This takes unconditional dependency on C++11 (in the form of including <array> and <memory>), while catch tries for C++03 conformance. Going to fix this later tonight.

@krvajal

This comment has been minimized.

Copy link
Collaborator

krvajal commented Jan 12, 2017

@philsquared any updates on this??

@philsquared

This comment has been minimized.

Copy link
Collaborator

philsquared commented Jan 12, 2017

@krvajalmiguelangel - I started work on my own signals fixes before I saw @horenmar's PR - and have now covered half of it - will look at the stack overflow part soon.

@horenmar

This comment has been minimized.

Copy link
Member

horenmar commented Jan 14, 2017

I cherry picked this into dev-signals branch, so the PR is obsolete.

@horenmar horenmar closed this Jan 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment