Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added Win32 UNICODE wmain support #903
I not against the change, but I have to ask what is the intended benefits of these changes? Catch will not be able to work with utf-8 encoded arguments anyway (well, not at this point) and tests should be able to have
Is there anything else that also changes when
The problem occurs if someone uses wmainCRTStartup in its project, or MinGW-w64 GCC with -municode flag.
The are no benefits in terms of performance, or for the UNICODE support in the strict meaning (as you said), but it will save a developer from writing the same code that I wrote in order to adapt the wmain interface to the Catch::Session run method.
Short answer: it's just a convenience to have it working even when the above switches are ON, and you don't have to care about adapting the code, cause wmain has wchar_t **, and not char **, as argv type.
I took another look and if you add proper configurations to AppVeyor, Ill merge it in.
If we add proper utf-8 support to Catch we might to go back and add error checking for invalid conversion, but right now non-ascii character set might break things anyway, no need for malformed utf.