Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pulling replacement activities #234

Open
EMorf opened this issue Mar 7, 2018 · 14 comments
Open

Stop pulling replacement activities #234

EMorf opened this issue Mar 7, 2018 · 14 comments
Labels
bug

Comments

@EMorf
Copy link
Collaborator

@EMorf EMorf commented Mar 7, 2018

I've had a few emails of students confusing make-up and regular tutorials. In particular, the scrapper is not able to differentiate between them and pulls both. So tutorials that occur only once as makeups appear to be regular tutorials on our timetable. Would it be possible to prevent the scrapper from storing activities that occur only once per semester?

@samyex6
Copy link
Collaborator

@samyex6 samyex6 commented Mar 7, 2018

It's possible if the scraper also fetches the week field from the source and we can implement a feature to show classes on a given week only.

Can you provide a course which such situations occur?

@EMorf
Copy link
Collaborator Author

@EMorf EMorf commented Mar 7, 2018

Here's the whole email:

Dear Emmanuel,

We have received many complaints that students are getting confused when they are using the ANU Timetable Builder http://anutimetable.com/.

Some classes are timetabled as makeup classes for some specific weeks only, however, the ANU Timetable Builder does not display the week/s that the makeup classes are timetabled. For example (screen shot shown below), Friday 9-10am for POLS2009 is a makeup Tutorial for one week only taken place last week.

Sometimes when room changes being updated to the timetable, the ANU Timetable Builder did not reflect the updates timely, as a result, it has caused further confusions.

It will be great if you can please remove the room information from the ANU Timetable Builder, so the students can check the ANU official Timetable website for room information and hence they are able to view the actual weeks for the classes being timetabled.

Please let know me if this kind of update is possible. Many thanks.

@EMorf
Copy link
Collaborator Author

@EMorf EMorf commented Mar 7, 2018

and the screenshot:

image001

@EMorf
Copy link
Collaborator Author

@EMorf EMorf commented Mar 7, 2018

tds.eq(6) has the weeks, which can be grabbed by the regex ((\d+-\d+)+,?)+ if it's any help.

@samyex6
Copy link
Collaborator

@samyex6 samyex6 commented Mar 7, 2018

Cool I'll try implement it on the weekend.

@samyex6
Copy link
Collaborator

@samyex6 samyex6 commented Mar 10, 2018

Implemented. However it still requires some testing.

The JSON structure now has an additional array at index 4 which stores the starting date and ending date of the semester, it's used to calculate the week offset and display them from 1 instead of week of the year.
Also each class now has note (additional info like 'makeup tutorial cuz of flooding', it'll appear as a hoverable button) and weeks (e.g. 8,10-12,14) field.

samyex6 added a commit that referenced this issue Mar 10, 2018
Added week switcher, also recovered location display #234
@EMorf
Copy link
Collaborator Author

@EMorf EMorf commented Mar 11, 2018

Wow, nicely done @samyex6 . I've fixed some bugs I found and now I'm comparing courses in random with the official timetable. So far it looks like it's perfectly accurate.

@samyex6
Copy link
Collaborator

@samyex6 samyex6 commented Mar 11, 2018

The source that's being pushed to the website is outdated and caused the website to be broken, you might want to update it asap

@EMorf
Copy link
Collaborator Author

@EMorf EMorf commented Mar 11, 2018

On it, almost done.

@samyex6
Copy link
Collaborator

@samyex6 samyex6 commented Mar 11, 2018

somehow tutorial choosing doesn't work anymore

@EMorf
Copy link
Collaborator Author

@EMorf EMorf commented Mar 11, 2018

Yep, I'm aware. I just pushed to avoid the website being down, the fix is coming soon. Just testing now.

@EMorf
Copy link
Collaborator Author

@EMorf EMorf commented Mar 11, 2018

@EMorf
Copy link
Collaborator Author

@EMorf EMorf commented Mar 11, 2018

Looks like there's still an issue due to tutorials being set as not having alternatives, which overwrites the saved ID which is chosen by the user... I'll investigate more tomorrow

@mdchia
Copy link
Collaborator

@mdchia mdchia commented Jul 23, 2018

The week switcher means that tutorials that appear later in the semester fail to appear on earlier weeks - current hotfix is to default to display to week 2, but there's probably a better way of handling this

@mdchia mdchia added the bug label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.