-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zed #2262
Comments
I can confirm no issues with it so far, looks really good. Nice job @tecandrew! |
This is fantastic. I dont see any issues either. Awesome work! @tecandrew |
Looks awesome! Thnx for the port. I also use the VS Code theme, but as flat appearance with minimal set, could you add that as a variation? Also the colours look a little different, but maybe that is because flat appearance. Now I hope we can set the catppuccin icons in the future in Zed |
Hey 👋, thanks for working on this! Theme
Codebase
Think we'll be good to transfer the repository into the organisation after the above changes have been implemented! |
Can add my 2 cents after using this theme for a couple of days and trying to tweak it:
Couple of screenshots:
|
Do you need something from me to research the issue? |
@sgoudham Got all but the last one in the repo 👍🏽 never heard of the other things addressed was update the borders as well: the lower contrast looks does look a bit better. regarding the Red color, the importer transferred over the "correct" color for the variables, but seems like there's 2 'flavors' for variables defined by zed to set: https://github.com/tecandrew/zed/blob/ac91f746cadd48eef030e0b8be3734bd74e19e7b/catppuccin.json#L289 throughout my testing on some local projects i can't seem to tell the affects on it. their schema doesn't have documentation notes on it either 🙃 |
Just an heads up, I was looking at the extensions repo and noticed that there is already a catppuccin theme that seems to be this: it seems to be a theme generated with the importer from VS Code instead of hand tuned but it is already there in the centralized extensions repo 🫠. |
Thanks for making the changes I outlined @tecandrew In regards to the red colour, the syntax highlighting keys seem to be 1:1 mapping to treesitter so I think we'd want to change our instance of I get the feeling that we'll need to iteratively improve on the syntax highlighting so I'm not too bothered about getting it close to our editors right now, that being said, I've just noticed some things that we can easily line up: (I'm assuming that Zed will be following the syntax highlights defined in nvim-treesitter)
For testing, I'd recommend that you check out our samples directory which has code samples for a bunch of popular languages. You could probably have Zed open on one side and VSCode on the other and review them both - making sure that nothing is too out of the ordinary. (Obviously there'll be differences in what the editor recognises as a "variable" or "type" but I think comparing against VSCode is a good sanity check) Hopefully should be good to transfer into the organisation after these changes since the UI/Syntax Highlighting is coming along nicely! Also thanks for being patient while we go back and forth on this! Really appreciate your (and everyone elses) inputs into making the theme nicer before transferring it ❤️ |
Yeah I noticed this too, I think it makes sense to try and upstream the theme here once merged and available as |
set the coloring recommendations you mentioned to be similar to treesitter. the sample codes are great! found some discrepancies that the importer didn't get quite right. few things I noticed from the samples:
|
Cheers! Thanks for updating it to be in line with VSCode @tecandrew I think what you've done with the brackets and variables is good given the limitations! The only change that I'd be looking for now is regenerating the In any case, the Please read, "Transferring a repository owned by your personal account", if you are unsure about the process of transferring the repository to Catppuccin. We'll close this issue once the port has been added to our ports.yml. You can find an example of this in #2164 (in this case, category would be |
no prob! I regenerated the catwalk images, but seemed like GitHub's relative links render thing took a bit to update the README previews. it should be good now 😄 from the Zed discord, staff mentioned they release a new Preview and Stable version every week. so likely the selection bug fix should get to Stable fairly soon edit: transferred 🫡 |
Link to repository
https://github.com/tecandrew/zed.git
Screenshots
Any additional comments?
Catppuccin
null
falls back to Zed default color (not sure what this is), but mostly look OKZed
- custom color themes currently only available in Zed PreviewSubmission Guidelines
edit:
there's a slight issue with the selection highlight color not being used in the terminal, and has been identified as a defect zed-industries/zed#7532Fixed in v0.123.2-pre. Should be in Stable soon
The text was updated successfully, but these errors were encountered: