Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDownloader Homepage breaks with Basic Auth #1830

Closed
rix1337 opened this issue Apr 30, 2022 · 11 comments · Fixed by rix1337/FeedCrawler#677 or #1904
Closed

JDownloader Homepage breaks with Basic Auth #1830

rix1337 opened this issue Apr 30, 2022 · 11 comments · Fixed by rix1337/FeedCrawler#677 or #1904

Comments

@rix1337
Copy link
Sponsor Contributor

rix1337 commented Apr 30, 2022

Organizr Version: 2.1.1890
Branch: Develop
WebServer: Nginx
Operating System: Unraid / Docker

Problem Description:

It is possible to enable Basic Authentification in the JDownloader API of FeedCrawler
Because there currently is no way to set username/password in the Homepage item's section I tried to add a URL like
http://user:pass@192.168.0.1

grafik
grafik

Sadly this has not worked for me and yields an error.

The URL including user and pass works with curl and inside webbrowsers:
grafik
grafik


Reproduction Steps:

Set up Username and Password in FeedCrawler.
Set URL with user:pass@IP
Test URL


Errors on screen? If so paste here:

grafik

@causefx
Copy link
Owner

causefx commented Apr 30, 2022

lemme do some testing.

@causefx
Copy link
Owner

causefx commented Apr 30, 2022

So this is using your feedcrawler package, and not the organizr standalone version - correct?

@rix1337
Copy link
Sponsor Contributor Author

rix1337 commented Apr 30, 2022

Yeah, but I am planning to roll out basic auth to the standalone, if we can get this working

@causefx
Copy link
Owner

causefx commented Apr 30, 2022

can you send me a config ini file so i can test on my end.

@rix1337
Copy link
Sponsor Contributor Author

rix1337 commented May 1, 2022

@causefx to make things easier I have just implemented the basic auth feature in the standalone version (MyJD-API).

If you run 1.0.0 locally you can use the --username and --password parameters to set basic auth credentials.
The docker image also now runs 1.0.0 but will not handle these new parameters, yet. You can however edit the ini at /config to yield the same result.

If it is possible to integrate the basic auth feature in Organizr, I'll later update the docker image as well.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@causefx
Copy link
Owner

causefx commented May 17, 2022

i'm still working on it

@github-actions
Copy link

This issue has been closed due to lack of activity, if this issue still persists, please re-open it.

@rix1337
Copy link
Sponsor Contributor Author

rix1337 commented Aug 16, 2022

Issue persists

@rix1337
Copy link
Sponsor Contributor Author

rix1337 commented Dec 28, 2022

@causefx I just sent a Pull Request that should fix this.

causefx added a commit that referenced this issue Dec 30, 2022
Implement JDownloader Homepage Basic Auth #1830
rix1337 pushed a commit to rix1337/MyJD-API that referenced this issue Jan 7, 2023
@rix1337
Copy link
Sponsor Contributor Author

rix1337 commented Jan 7, 2023

@causefx Thanks for releasing the PR. I found some further issues that need adressing.

I have updated both MyJD-API as well as FeedCrawler to properly handle missing trailing slashes.

For some reason the PHP Requests library swallows trailing slashes, which my tools both expect, resulting in a 404.

That 404 has now been resolved on my end, leading to another error in the way my last PR handles authentification.

I have now locally debugged and fixed this as well. Will be sending over a PR with the fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants