Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes + refactor SVG handing #31

Merged
merged 6 commits into from Nov 2, 2018
Merged

Minor fixes + refactor SVG handing #31

merged 6 commits into from Nov 2, 2018

Conversation

bettse
Copy link
Contributor

@bettse bettse commented Mar 10, 2018

This is a big mess right now, but I wanted to start the conversation. I was noticing that when I added my own layout data then added the rotation prop to make it accurate to reality, the triangles looked a bit wonky (I can go back and screenshot this if its of use). My thought was that the triangle creation math might be over complicated since the triangles can be rotated in a <g> element after they're created. In the process, I also found that with the viewBox and some other tweaks, the SVG could generate its results without concern for an explicit height/width (making it more responsive), and supporting rotation without the need for the x/y offsets to correct for it (that's what they seemed to be for; if I'm wrong, let me know).

Here are screenshots of the demos based on my new code.

screen shot 2018-03-10 at 2 56 38 pm

screen shot 2018-03-10 at 2 56 44 pm

screen shot 2018-03-10 at 2 56 55 pm

@cbartram
Copy link
Owner

@cbartram cbartram commented Nov 2, 2018

Hey sorry for being so late to review this let me check it out real quick!

Copy link
Owner

@cbartram cbartram left a comment

Looks good to me!

@cbartram cbartram merged commit a26bbce into cbartram:development Nov 2, 2018
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants