add missing catches to allow compilation... #343
Conversation
…s (eg., Fedora 24-25) Signed-off-by: nickboldt <nboldt@redhat.com>
| @@ -65,6 +65,10 @@ public Object execute(ExecutionEvent event) throws ExecutionException { | |||
| TestNGPlugin.log(e1); | |||
| } catch (CoreException e) { | |||
| TestNGPlugin.log(e); | |||
| } catch (ParserConfigurationException e) { | |||
There was a problem hiding this comment.
these catch blocks failed the travis build.
actually, I don't mind if you catch a more generic Exception
There was a problem hiding this comment.
Yeah, it's weird... this worked for me inside a mock build for F24 and F25, and worked in Eclipse using PDE to build automatically. But failed your travis build. So... maybe you're right - a generic Exception catch might be the better solution. I'll concoct a different patch and submit that instead.
| @@ -228,6 +231,10 @@ private void createXmlFileFromTemplate(XMLStringBuffer suiteBuffer, String fileN | |||
| } | |||
| } catch (IOException e) { | |||
There was a problem hiding this comment.
@nickboldt , I think you can catch the generic Exception here rather than add more catch block which fail the travis build
|
@nickboldt, would you like to update the PR so that I can make it into 6.12 release? |
|
Replaced by #353 |
add missing catches to allow compilation against older testng versions (eg., Fedora 24-25)
Signed-off-by: nickboldt nboldt@redhat.com