Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Listeners added via ServiceLoader are not being run #491

Closed
alechenninger opened this issue Feb 22, 2014 · 2 comments
Closed

Comments

@alechenninger
Copy link

I can't tell if this is a problem with SuiteRunner or TestRunner or what exactly, but I can't find where either of them are looking at ConfigurationListeners added via ServiceLoader. I can see that ServiceLoader is indeed finding them, and they are being added to the Configuration. Ultimately at line 1862 of Invoker.java, m_notifier.getConfigurationListeners() is not returning the listener added via ServiceLoader.

If I find time I will try to investigate further and submit a pull request.

juherr added a commit to juherr/testng that referenced this issue Sep 19, 2015
@juherr
Copy link
Member

juherr commented Sep 19, 2015

I'm not able to reproduce the issue. Could you have a look on #806 where I added a test and tell me if you see something wrong?

@krmahadevan
Copy link
Member

Closing this off based on the above comment. Please comment if this problem continues to exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants