Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bux where Strings.join returns empty String #2465

Merged
merged 4 commits into from Jan 24, 2021
Merged

Fix bux where Strings.join returns empty String #2465

merged 4 commits into from Jan 24, 2021

Conversation

@sgilson
Copy link
Contributor

@sgilson sgilson commented Jan 24, 2021

When Strings.join is given an array with length of 1, it returns an empty String instead of the first element.

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
sgilson added 3 commits Jan 23, 2021
When Strings.join is given a single element, an empty String is returned instead of the element.
/**
* Unit tests for {@link Strings}
*
* @author Spencer Gilson

This comment has been minimized.

@krmahadevan

krmahadevan Jan 24, 2021
Collaborator

@sgilson - Can you please remove off the author tag ?

@krmahadevan krmahadevan requested a review from juherr Jan 24, 2021
@krmahadevan krmahadevan added this to the 7.4.0 milestone Jan 24, 2021
@juherr juherr merged commit 378e63e into cbeust:master Jan 24, 2021
3 checks passed
3 checks passed
Java 8 Build
Details
Java 9 Build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sgilson sgilson deleted the sgilson:strings-util-fix branch Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants