Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2469 #2470

Merged
merged 5 commits into from Feb 3, 2021
Merged

Issue #2469 #2470

merged 5 commits into from Feb 3, 2021

Conversation

@aditya-qapitol
Copy link
Contributor

@aditya-qapitol aditya-qapitol commented Jan 28, 2021

Fixes #2469

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
@juherr juherr requested a review from krmahadevan Jan 28, 2021
Copy link
Collaborator

@juherr juherr left a comment

LGTM as all tests pass.
Just some minor remarks.

# Conflicts:
#	CHANGES.txt
Copy link
Collaborator

@krmahadevan krmahadevan left a comment

Can you please help fix the observation

@krmahadevan krmahadevan merged commit 7fed142 into cbeust:master Feb 3, 2021
3 checks passed
3 checks passed
Java 8 Build
Details
Java 9 Build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants