Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configurable start time - emailable report #2476

Conversation

@bazzani
Copy link
Contributor

@bazzani bazzani commented Feb 7, 2021

The EmailableReport2 class provides test start time values which
are in millisecond value from the epoch (01/01/1970 00:00:00):

  • sample value 1610359715103
    • GMT : January 11, 2021 Monday 10: 08: 35.103
  • see test-output/emailable-report.html for start time report usage
  • see https://www.epochconverter.com/clock

This value is not very human readable, and this change adds a protected
method which can be overridden in sub classes to provide a more human
readable version of the test start time (e.g. 2021-01-01 12:34:56)

Fixes #2459.

Did you remember to?

  • Add test case(s)
    • I could not find any existing test cases to update, please let me know if I should add/update any in this PR @krmahadevan
  • Update CHANGES.txt
The `EmailableReport2` class provides test start time values which
are in millisecond value from the epoch (01/01/1970 00:00:00):
- sample value `1610359715103`
  - GMT : January 11, 2021 Monday 10: 08: 35.103
- see `test-output/emailable-report.html` for start time report usage
- see https://www.epochconverter.com/clock

This value is not very human readable, and this change adds a protected
method which can be overridden in sub classes to provide a more human
readable version of the test start time (e.g. `2021-01-01 12:34:56`)

Fixes #2459
@juherr juherr requested a review from krmahadevan Feb 7, 2021
@juherr
juherr approved these changes Feb 7, 2021
@bazzani bazzani requested a review from juherr Feb 7, 2021
@juherr
juherr approved these changes Feb 7, 2021
@krmahadevan krmahadevan merged commit e016840 into cbeust:master Feb 7, 2021
3 checks passed
3 checks passed
Java 8 Build
Details
Java 9 Build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bazzani bazzani deleted the bazzani:add-support-for-human-readable-start-times branch Feb 7, 2021
@bazzani bazzani restored the bazzani:add-support-for-human-readable-start-times branch Feb 7, 2021
@bazzani bazzani deleted the bazzani:add-support-for-human-readable-start-times branch Feb 7, 2021
@bazzani bazzani restored the bazzani:add-support-for-human-readable-start-times branch Feb 7, 2021
@bazzani bazzani deleted the bazzani:add-support-for-human-readable-start-times branch Feb 24, 2021
@bazzani
Copy link
Contributor Author

@bazzani bazzani commented Feb 24, 2021

@krmahadevan / @juherr may I ask when this feature/fix for this issue will be released?

In other words, when is the next release of testng due, so that I can start using the new feature I added in this PR in my other projects which implement/run testng tests?

@krmahadevan
Copy link
Collaborator

@krmahadevan krmahadevan commented Feb 24, 2021

@bazzani - It should be released this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants