Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP v2- Streaming API #52

wants to merge 66 commits into from

WIP v2- Streaming API #52

wants to merge 66 commits into from


Copy link

@cblage cblage commented Apr 11, 2018

Stream json content and emit streams of json tokens in order to fix the current perf issues plaguing the lib.

Copy link

coveralls commented Apr 22, 2018

Pull Request Test Coverage Report for Build 487

  • 41 of 69 (59.42%) changed or added relevant lines in 7 files are covered.
  • 48 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-35.2%) to 49.718%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/json.ex 5 8 62.5%
lib/json/encoder/default_implementations.ex 11 16 68.75%
lib/json/parser.ex 12 17 70.59%
lib/json/decoder.ex 8 23 34.78%
Files with Coverage Reduction New Missed Lines %
lib/json/decoder.ex 1 38.46%
lib/json/parser/unicode.ex 4 37.5%
lib/json.ex 5 40.91%
lib/json/parser/object.ex 5 61.54%
lib/json/parser/string.ex 7 50.0%
lib/json/parser/array.ex 8 50.0%
lib/json/parser.ex 18 34.29%
Totals Coverage Status
Change from base Build 479: -35.2%
Covered Lines: 88
Relevant Lines: 177

💛 - Coveralls

@cblage cblage changed the title v2 in progress WIP v2- Streaming API Apr 22, 2018
Copy link
Owner Author

@cblage cblage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants