Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP v2- Streaming API #52

Open
wants to merge 66 commits into
base: develop
from
Open

WIP v2- Streaming API #52

wants to merge 66 commits into from

Conversation

@cblage
Copy link
Owner

@cblage cblage commented Apr 11, 2018

Stream json content and emit streams of json tokens in order to fix the current perf issues plaguing the lib.

@cblage cblage added this to the 2.0 milestone Apr 11, 2018
@cblage cblage self-assigned this Apr 11, 2018
@cblage cblage force-pushed the develop branch from 43dcdf3 to bd1b4ac Apr 12, 2018
@cblage cblage force-pushed the develop branch from 3b4f9ed to 31e42de Apr 13, 2018
@coveralls
Copy link

@coveralls coveralls commented Apr 22, 2018

Pull Request Test Coverage Report for Build 487

  • 41 of 69 (59.42%) changed or added relevant lines in 7 files are covered.
  • 48 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-35.2%) to 49.718%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/json.ex 5 8 62.5%
lib/json/encoder/default_implementations.ex 11 16 68.75%
lib/json/parser.ex 12 17 70.59%
lib/json/decoder.ex 8 23 34.78%
Files with Coverage Reduction New Missed Lines %
lib/json/decoder.ex 1 38.46%
lib/json/parser/unicode.ex 4 37.5%
lib/json.ex 5 40.91%
lib/json/parser/object.ex 5 61.54%
lib/json/parser/string.ex 7 50.0%
lib/json/parser/array.ex 8 50.0%
lib/json/parser.ex 18 34.29%
Totals Coverage Status
Change from base Build 479: -35.2%
Covered Lines: 88
Relevant Lines: 177

💛 - Coveralls
@cblage cblage changed the title v2 in progress WIP v2- Streaming API Apr 22, 2018
Copy link
Owner Author

@cblage cblage left a comment

So far so good

@cblage cblage force-pushed the develop branch 2 times, most recently from b52cfcd to ce96ae4 Apr 23, 2018
cblage added 16 commits Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.