Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support min/max(x,y) #876

Closed
cbm755 opened this issue Mar 20, 2018 · 2 comments
Closed

support min/max(x,y) #876

cbm755 opened this issue Mar 20, 2018 · 2 comments
Labels
enhancement help wanted

Comments

@cbm755
Copy link
Collaborator

cbm755 commented Mar 20, 2018

should be Max(x,y) in Sympy
@skelter
Copy link

skelter commented Oct 31, 2018

cloned it locally. taking a look

cbm755 added a commit that referenced this issue Jan 24, 2019
@cbm755
min/max: support expressions like "min(x,y)"
a4e239b 
Use `sympy.Min` instead of Python's `Min`.  This only works for the
single-output versions (that do not return indices).  When indices
are requested, continue to use `min`.  This increases code complexity
are there are two paths, and it was already fairly complex.  Add more
tests.

Fixes Issue #876.
@cbm755
Copy link
Collaborator Author

cbm755 commented Jan 24, 2019

Issues aren't autoclosing, I think b/c the syntax should be "Fixes #876" not "Fixes Issue #876".

@cbm755 cbm755 closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbm755 @skelter