This repository has been archived by the owner on Jan 18, 2020. It is now read-only.
Fix action argument for the --no-fake option #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If possible, can you add a test that:
|
|
Whoops, time to add a pyflakes pre-commit hook. I'll also look at adding a unit test. |
This test case is not a proper test for the fix, however. To actually test the fix, we would have to use a shell command instead of the internal API, which would necessitate converting TransactionTestCase to TestCase, which would hose many of the test methods in BackupTestCase.
|
@naegelyd, as noted in my commit message, the test case I added addresses the use of the --no-fake switch via the internal API (but that would always have passed anyway). It doesn't actually test the command-line switch processing; to do that, I think I would have to refactor the BackupTestCase class to extend TestCase instead of TransactionTestCase. Is it worth it? |
|
No, don't worry about it. |
naegelyd
added a commit
that referenced
this pull request
Feb 17, 2014
Fix action argument for the --no-fake option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.