Skip to content

/ knitcitations

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip should render HTML markup #37

Closed
cboettig opened this issue Apr 16, 2013 · 3 comments
Closed

Tooltip should render HTML markup #37

cboettig opened this issue Apr 16, 2013 · 3 comments
Labels
bug

Comments

@cboettig
Copy link
Owner

@cboettig cboettig commented Apr 16, 2013

Bug reported here: cboettig/labnotebook#90

Looks like I just need to generate html syntax for the tooltip, and then set data-html="true" http://stackoverflow.com/questions/13704789/can-i-use-complex-html-with-twitter-bootstraps-tooltip
cboettig added a commit that referenced this issue Apr 16, 2013
@cboettig
v0.4-6
6073e0c 
* Tooltip provides HTML formatting, with link (issue [#37](#37))
* html print method now handled directly in knitcitations just like the markdown print method, with ordering, etc, since default html printing method sucks
@cboettig
Copy link
Owner Author

@cboettig cboettig commented Apr 16, 2013

Closed by 6073e0c
@cboettig cboettig closed this Apr 16, 2013
cboettig added a commit that referenced this issue Apr 18, 2013
@cboettig
html in tooltips removed, see NEWS #37
0dd4cd5
@cboettig
Copy link
Owner Author

@cboettig cboettig commented Apr 19, 2013

Looks like this should work if the html tags are all escaped. Should be a CGI escape filter function call for that I can just swap in...
@cboettig cboettig reopened this Apr 19, 2013
@cboettig cboettig mentioned this issue Apr 29, 2013
Closed
@cboettig
Copy link
Owner Author

@cboettig cboettig commented Jun 19, 2013

This would work for twitter-bootstrap tooltips but not for browser-based tooltips (#43) anyway. No need to provide html in a tooltip, does not seem standard practice (and may indeed be a security risk). #wontfix this one.
@cboettig cboettig closed this Jun 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@cboettig
You can’t perform that action at this time.