Ad review #20
Merged
Ad review #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcr
approved these changes
Apr 3, 2022
cabo
reviewed
Apr 3, 2022
| @@ -373,7 +373,8 @@ potential CoAP Content-Format number (examples are in {{ct-tags}}). | |||
| ## Labeled CBOR Sequence Tag {#cbor-sequence-tag} | |||
|
|
|||
| IANA has allocated tag 55800 as the tag for the Labeled CBOR Sequence | |||
| Enveloping Method. | |||
| Enveloping Method from the CBOR Tags Registry. | |||
There was a problem hiding this comment.
The introduction to 5 already says this, with an actual reference.
But maybe some more redundancy does not hurt.
cabo
reviewed
Apr 3, 2022
cbor-file-magic.mkd
Outdated
|
|
||
| Reference: | ||
| : RFCthis | ||
|
|
||
| {{RFC7252}} has defined the Content-Format registry, which is present at: |
There was a problem hiding this comment.
That's not the way we do this...
I'll push an update.
|
Note sure I can approve a PR that I originally created, but with your additions this now looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.