Adding UT1 #9
Closed
Adding UT1 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabo
reviewed
Oct 19, 2022
| PTP (Precision Time Protocol) epoch {{IEEE1588-2008}}; the value 2 | ||
| indicates UT1 (Earth Rotation Angle), as defined by the International | ||
| Earth Rotation and Reference Systems Service (IERS) and illustrated by | ||
| the reference terminology in ANNEX 1 of {{ITU-R_TF.460-6}}. |
There was a problem hiding this comment.
This is a bit of a lame reference, as its main content is "Concise definitions of the above terms and the concepts involved are available in the publications of the IERS (Paris, France)." What are those IERS documents? We'd need to say this here...
| @@ -312,7 +322,10 @@ Key -1: Timescale {#key-timescale} | |||
|
|
|||
| Key -1 is used to indicate a timescale. The value 0 indicates UTC, | |||
| with the POSIX epoch {{TIME_T}}; the value 1 indicates TAI, with the | |||
| PTP (Precision Time Protocol) epoch {{IEEE1588-2008}}. | |||
| PTP (Precision Time Protocol) epoch {{IEEE1588-2008}}; the value 2 | |||
| indicates UT1 (Earth Rotation Angle), as defined by the International | |||
There was a problem hiding this comment.
We don't say the Epoch here (only in the IANA table later).
| @@ -664,6 +677,7 @@ The initial contents are shown in {{tab-timescales}}. | |||
| | Timescale | Value | Semantics | Reference | | |||
| | UTC | 0 | UTC with POSIX Epoch | [RFCthis] | | |||
| | TAI | 1 | TAI with PTP Epoch | [RFCthis] | | |||
| | UT1 | 2 | UT1 with POSIX Epoch | [RFCthis] | | |||
There was a problem hiding this comment.
Is the POSIX epoch defined for UT1? What was the UT1 value at 1970-01-01T00:00Z (UTC)? We probably need to say.
|
In the interim, we were a bit skeptical this PR is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.