Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module content just stopped displaying #16

Closed
pyrosmiley opened this issue Oct 2, 2017 · 8 comments
Closed

Module content just stopped displaying #16

pyrosmiley opened this issue Oct 2, 2017 · 8 comments

Comments

@pyrosmiley
Copy link
Contributor

Not really sure what's going on with this one. It worked excellently for awhile (several weeks at least!) and then boom it's stopped showing up since the other day. The module header is there, but there's no list. I've checked my config and I've deleted/reinstalled the module entirely, but there's just no content. Thought I had maybe messed it up while trying to change CSS but I didn't modify this one at all.

@hutny1980
Copy link

Myself and a friend are experiencing the same issue as @pyrosmiley

@larsauswsw
Copy link

larsauswsw commented Oct 4, 2017

@hutny1980 @pyrosmiley Did you made the update of the MagicMirror to version 2.13 from 2017-10-01?

Have the same issue after/with update of MagicMirror.

@hutny1980
Copy link

@larsauswsw - yes, recently upgraded MagicMirror and still not working. Here's the config:

{
module: 'MMM-Todoist',
position: 'top_left', // This can be any of the regions. Best results in left or right regions.
header: 'Reminders', // This is optional
config: { // See 'Configuration options' for more information.
accessToken: 'REMOVED',
maximumEntries: 60,
updateInterval: 60,
projects: [2163568809],
fade: false,
showProject: false
}
},

@baz4096
Copy link

baz4096 commented Oct 5, 2017

Figured out the problem.

In MMM-Todoist.js

apiBase: "https://todoist.com/API/",

But it looks like Todoist are enforcing case sensitive URLs now (perhaps this is why there's an unexpected issue)

I changed mine to

apiBase: "https://todoist.com/api",

And it works now.

I also dropping the trailing '/' due to it being doubled up when used in the fetcher.js code.

Too much of a github noob to work out how to commit changes I'm afraid, hopefully someone else can do so? :(

@hutny1980
Copy link

@baz4096 - how the heck did you work that out!! Changed apiBase to "https://todoist.com/api", as suggested and working like a charm.

Huge thanks for all your help.

@baz4096
Copy link

baz4096 commented Oct 5, 2017

@hutny1980 You're very welcome. I'm an ex-web php/js dev and now a full time c++ dev, so I just stepped through the code and added some console.error("Messages") in various places until I figured it out.

I suspect that http://todoist.com/API was recently setup to redirect to their API docs, and most likely broke their actual REST API available on http://todoist.com/api/

@pyrosmiley
Copy link
Contributor Author

@hutny1980 @baz4096 wow you're awesome, thanks so much!! All I know is [very] rudimentary python, so trying to sus out the problem was not going well. AFAIK, the only way to ask for commits is to fork it and then put in a pull request. If you don't mind, I'll go ahead and do it (with full credit, of course!!) just so that the fix is available for people. That way there's something there until the original author can get to merging everything in the main repository.

pyrosmiley added a commit to pyrosmiley/MMM-Todoist that referenced this issue Oct 6, 2017
@pyrosmiley
Copy link
Contributor Author

I made the change and submitted a pull request right here at the main branch.

For anyone just stumbling across this issue, until that pull request is merged into the main distro, I have a working clone of the module that I forked to integrate the fix, so if you'd rather just download a working version of it temporarily, that should do. I have no plans to continue updating it or make any other changes though, so it probably won't stay up-to-date with OP's module!

cbrooker added a commit that referenced this issue Oct 13, 2017
Fixed Todoist API URL as per @baz4096 fix in issue #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants