Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS support #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add HTTPS support #19

wants to merge 2 commits into from

Conversation

wizcheng
Copy link

@wizcheng wizcheng commented Sep 1, 2017

No description provided.

@cburgmer
Copy link
Owner

cburgmer commented Sep 1, 2017

Hey Wiz, thanks a lot for merging back the changes.

I understand you wanted to make both the trust and the key store configurable via the client.

I assume http-kit's client did not offer the option, which is the reason you replaced it? I don't mind the new client, if it provides the same promise of non-blocking calls.

Before we talk about merging, can I ask whether configuring trust and key store via JVM parameters didn't work out for you? I remember configuring it via the JVM directly, similar to what's described here: http://blog.kunicki.org/blog/2015/09/10/ssl-client-certificates-on-the-jvm/.

I'll probably won't have much time the next days, my answer's might be delayed. But I wanted to give you an initial response as quickly as possible now.

@cburgmer cburgmer mentioned this pull request Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants