Disable too-aggressive optimization in OptCmp8 #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generates incorrect code for some 16-bit cases. See: cc65#895
|
Please add a test case of the bug to test/val, to increase coverage and make sure it stays fixed. |
|
Thank you @clbr for that suggestion. I have added a unit test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This optimization generates incorrect code for some 16-bit cases (possibly others). See: #895
I'm not sure if it would be better to re-evaluate how the compiler generates a shared branch so that this optimization could be kept, but this change is simple and will prevent it from being broken by the attempted optimization.
The text was updated successfully, but these errors were encountered: