Visual C/C++ compatibility #162

jd-gascuel · 2017-03-11T16:07:08Z

Hi Joel,

I started a fork to try to make changes to ccache, so we can compile and use it for windows.
In the following you will see:

A bunch of small cleanups to make Visual compiler happy. Mostly bad includes and missing definition on windows. All them should be completly transparent, and I think will improve the main branch quality.
There is a few 32/64 bits issues that might deserve a better correction. I just casted them down to 32 bits...
I added a compiler_is_msvc() at the top of ccache.c, and started a table of options specific to the Visual compilers.
Plus a few management of specific options.

So it starts to work, and knows how to compile itself.

Known issues:

cl compiler do write part of the error messages into stdout, and other parts to stderr. This cannot be avoided... So I just made a concatenation of stdour+stderr->stderr. Not very clean, and a better approach might be: 1) to change the execute() function to have only one file, or 2) have ccache to can both stdout and stderr outputs. Note both solution won't keep sync between lines send to stdout and stderr, which might be confusing... but is truly microsoft's fault.
cl options can be /option or -option : I did not deal with that properly yet. But this should not be too hard.
I should investigate on @file support.
I have not a very clear view of what option shall be and shall not be in the compopts_msvc table.

Futur ?
The main question here is: how to contribute that to ccache ?

Are you happy to have a windows branch in the official ccache repo ? and to merge it to the default trunk once it works great ?
Is there a way to can other annex files (cl generates .sbr files with complete symbolic information) into the cache, so we can restore them too ?

Best regards,

Note: I used Visual 2015 to compile, because earlier version will shock on variable definition inside for().

Add Windows specific includes

…as 32 bits.

…h STDERR...

…sis. FIX: option /FoDebug/x64/ can be just a directory: concatenate the object name.

I picked only the compiler commits from: ccache#162 The following commits I've adapted to the latest ccache C++ code: 375fe24: Add compiler_is_msvc() and MSVC specific option table. 7e01763: Add handling of /Fo option (replaces -o, but shall have no space) 0c5cd25: Manage /E, /c equivalence. -g is gcc only. -O or /O is msvc only. 4f61b59: MSVC send part of the error/warning messages to STDOUT, so concat wit…

I picked only the compiler commits from: ccache#162 The following commits I've adapted to the latest ccache C++ code: 375fe24: Add compiler_is_msvc() and MSVC specific option table. 7e01763: Add handling of /Fo option (replaces -o, but shall have no space) 0c5cd25: Manage /E, /c equivalence. -g is gcc only. -O or /O is msvc only. 4f61b59: MSVC send part of the error/warning messages to STDOUT, so concat wit… 64449d6: use common code for gcc an cl response files.

I picked only the compiler commits from: ccache#162 The following commits I've adapted to the latest ccache C++ code: 375fe24: Add compiler_is_msvc() and MSVC specific option table. 7e01763: Add handling of /Fo option (replaces -o, but shall have no space) 0c5cd25: Manage /E, /c equivalence. -g is gcc only. -O or /O is msvc only. 4f61b59: MSVC send part of the error/warning messages to STDOUT, so concat wit…

jd-gascuel added 29 commits March 8, 2017 19:01

Make sure to use HAVE_XXX from config.h

9f9fe82

Add Windows specific includes

Warning: float constant with trailing f

3635149

Add pre-configured config_win32.h, to skip configure script.

2c05c35

Windows misses ssize_t and pid_t

5b60f66

Replace opendir/readdir by Windows FindFirstFile/FindNextFile

f161f6e

Fix size_t/unsigned warnings: use (unsigned) for short string's length.

933d139

Skip support of color terminal on windows.

5a66d40

Add manual version.c file, to skip configure script.

f1714fb

All extern declarations SHALL be defined somewhere.

1c92d9b

Fix warning: printf %s wants a char*, not a void*

0266402

Fix warning: path_max() SHALL return something on Windows.

586e316

Fix update_mtime() to use Windows variant.

2c01850

Fix warnings when mixing int and size_t values.

53a9d46

Fix warnings between floats and uint64

8246ec1

Fix mdfour.totalN is 64 bits, file_hash.size is only 32 bits.

c646109

Fix warnings: struct counters data is only 32 bits.

875dd8a

Fix warnings about missing const

d61c50c

Fix warnings about va_arg() returning 64 bits.

c1ef7f7

Fix warning: cast time_t down to int (for hashing purpose)

f203678

Fix warnings: collect number of files as 64 bits, but store in stats …

0eb31a9

…as 32 bits.

Fix warning: GetFileNameFromHandle us 16 bits filename length.

248a7d4

... minor cleanups

4227fa0

Add compiler_is_msvc() and MSVC specific option table.

375fe24

Add handling of /Fo option (replaces -o, but shall have no space)

7e01763

MSVC send part of the error/warning messages to STDOUT, so concat wit…

4f61b59

…h STDERR...

Manage /E, /c equivalence. -g is gcc only. -O or /O is msvc only.

0c5cd25

Travis: gcc/clang to know about || vs. && priority and wants parenthe…

60fe7bf

…sis. FIX: option /FoDebug/x64/ can be just a directory: concatenate the object name.

compiler_is_msvc() shall not return TRUE for clang

31f03f0

static analyzer: Do not call str_eq() on a possibly null pointer ?

919f8be

jd-gascuel changed the title ~~Windows~~ Visual C/C++ compatibility Mar 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Visual C/C++ compatibility #162

Visual C/C++ compatibility #162

jd-gascuel commented Mar 11, 2017

Visual C/C++ compatibility #162

Visual C/C++ compatibility #162

Conversation

jd-gascuel commented Mar 11, 2017