Skip to content
This repository

Add unbind method #15

Closed
davoclavo opened this Issue · 6 comments

3 participants

David Ben Oakes Craig Campbell
David

There should be a way to disable a single key combo, instead of using reset().

David

I did this simple yet not so fancy solution, without the need to go through all the bind methods to 'parse' the keys, instead it replaces the callback with an empty function and removes its entry from _direct_map dict
davoclavo@105c853

edit: How do I add commits to my comments :P?

Ben Oakes

I'm just randomly stopping by, but I figure I can help, so I will. :smile:

@davoclavo You should probably make a pull request instead. If you're unfamiliar:

  • Go to your fork
  • Click the "pull request" button
  • Add a description, etc.
  • Check the "diff" tab to make sure the code you're intending to contribute shows up
  • Submit it
David

Thanks!

I just sent the pull request, but I can't find a way to link that request to this issue... shall I do it manually?

Ben Oakes

I think just mentioning the issue number will get us what we want: #31

David

thanks again!

Ben Oakes

np, happy hacking :smile:

Craig Campbell ccampbell closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.