Add unbind method #15

Closed
davoclavo opened this Issue Jul 6, 2012 · 6 comments

Projects

None yet

3 participants

@davoclavo
Contributor

There should be a way to disable a single key combo, instead of using reset().

@davoclavo
Contributor

I did this simple yet not so fancy solution, without the need to go through all the bind methods to 'parse' the keys, instead it replaces the callback with an empty function and removes its entry from _direct_map dict
davoclavo@105c853

edit: How do I add commits to my comments :P?

@benjaminoakes

I'm just randomly stopping by, but I figure I can help, so I will. 😄

@davoclavo You should probably make a pull request instead. If you're unfamiliar:

  • Go to your fork
  • Click the "pull request" button
  • Add a description, etc.
  • Check the "diff" tab to make sure the code you're intending to contribute shows up
  • Submit it
@davoclavo
Contributor

Thanks!

I just sent the pull request, but I can't find a way to link that request to this issue... shall I do it manually?

@benjaminoakes

I think just mentioning the issue number will get us what we want: #31

@davoclavo
Contributor

thanks again!

@benjaminoakes

np, happy hacking 😄

@ccampbell ccampbell closed this Jul 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment