Also stop keybindings from firing when focused on contenteditable element #27

Merged
merged 1 commit into from Jul 7, 2012

Projects

None yet

3 participants

@mikecrittenden
Contributor

No description provided.

@ccampbell ccampbell merged commit 5e971c2 into ccampbell:master Jul 7, 2012
@ccampbell
Owner

Hey I had to revert this change in 3b654f4 because I realized that it breaks Internet Explorer. Hopefully there is another way to check that doesn't require adding a lot of code.

@maxwell
maxwell commented Jul 16, 2012

I'd love this feature to get merged in; I currently am using @mikecrittenden fork and I'd love to just be on the master branch!

(if there is a better place to +1 this feature request, I am happy to delete this and direct it somewhere more productive)

@ccampbell
Owner

@maxwell Sorry about this. I think I have a fix. Testing now in old IE

@maxwell
maxwell commented Jul 16, 2012

@ccampbell no need to apologize! I am really grateful that your awesome library exists, and totally understand why you had to revert it. And thanks also for getting a fix in ASAP!

@mikecrittenden mikecrittenden deleted the mikecrittenden:patch-1 branch Mar 4, 2013
@mikecrittenden
Contributor

Just a quick note that this fix only works on sites using contenteditable="true". Google Plus, for example, uses the nonstandard contenteditable="plaintext-only", so if you're having trouble getting this working, make sure that contenteditable isn't set to something besides "true".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment