Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Request: Non-Conflicting Class Names #81

Open
tmaiaroto opened this Issue Aug 18, 2012 · 1 comment

Comments

Projects
None yet
2 participants

Hi,

I know this kinda stinks...But for closing tags, the close class is applied to the span element. There's a conflict with this and Twitter Bootstrap which defines styles for .close globally. I couldn't seem to flip the CSS around in the right order to avoid conflict.

I know it's literally impossible to know what people may be using alongside Rainbow...But perhaps prefixing class names with something like rainbow-close for example. Something more unique so that this doesn't happen. close is a very common word and class name. You'll have all sorts of close classes for buttons and links to close dialogs, etc.

Unless Rainbow is used in a sterile environment, then we're left to hack it up and I'd rather not for maintenance reasons. It's much nicer to just be able to grab updates without having to go back in and edit things.

I totally understand if this is low on your priority list there...But I think it's pretty important.

Thanks.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment