Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added documentation and style changes #85

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants

I dug some time to find information on how to build the minified version, so afterwards I figured it'd be document how this can be done. I also separated themes and general layout concerns, because I think it makes sense to influence the design of code blocks (margin, padding, borders, ...) apart from the used theme.

Let me know what you think.

dennisreimann added some commits Oct 16, 2012

@dennisreimann dennisreimann add documentation on building
and allow a custom build script to be present but ignore it (build.sh)
44c4420
@dennisreimann dennisreimann separate themes and general layout concerns
makes it easier to influence the design of code blocks apart from the used theme
ceb861e
@dennisreimann dennisreimann Bump version number to 1.2.0 71acdd4
@dennisreimann dennisreimann added xml highlighting dd4a00d
Owner

ccampbell commented Oct 23, 2012

Hey sorry for not commenting on this before. I am all for adding the additional documentation about building, but I'm not crazy about breaking out the css.

I understand that from a code duplication standpoint it cuts down on the code, but I don't want to encourage people to include multiple stylesheets. The way I see it is each theme should be fully designed and work itself out of the box. It should be up to the author/designer exactly how that theme should look so the font-size/border-radius/padding should be up to the designer for that theme. The fact that they all include the same base styles is because everyone ended up copying and pasting from the first theme I created.

I want this library to be as simple as possible to use and I think that means including one javascript file (if custom built) and one css theme file. If you want to customize the base styles of the theme you can, of course, overwrite them by adding your own css after the theme css.

Hey Craig, thanks for the comment.

If you want to customize the base styles of the theme you can, of course, overwrite them by adding your own css after the theme css.

That's exactly what I ended up with and it works fine for me.

Cheers,
Dennis

@ccampbell ccampbell closed this in 83095f2 Dec 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment