Skip to content

Fix encoders referncing the primary classes encoder #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2020
Merged

Fix encoders referncing the primary classes encoder #69

merged 2 commits into from
Jan 28, 2020

Conversation

@ptwales
Copy link
Contributor

@ptwales ptwales commented Jan 27, 2020

If I have a file Foo.tmpl which defines the type Foo: {...}, codegen gives it
a json encoder called just jsonEncoder, no suffix. But if you define another
type Bar: f: Foo } in the same file, when it tries to encode f it will assume
it needs to use a jsonEncoderFoo and the generated scala won't compile.

Philip Wales added 2 commits January 27, 2020 14:53
Encoders of the primary class don't need a suffix
6b9d336 
This was fixed with external references but not when internally
referencing the primary class
Rename classFile to primaryClass
e387b51
@ptwales ptwales merged commit 6b5dc9d into ccap:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ptwales